@Keyrxng, this task has been idle for a while. Please provide an update.

@Keyrxng, this task has been idle for a while. Please provide an update.

@henalolp, this task has been idle for a while. Please provide an update.

• text-vector-embeddings - fix(config): add descriptions to JSON schema properties ubiquity-os-marketplace/text-vector-embeddings#49 was closed so this has no descriptions.

• text-vector-embeddings - homepage_url is wrong https://github.com/ubiquity-os-marketplace/text-vector-embeddings/blob/c2d9d905691c2212be10bba46b6e7f5c73711914/manifest.json#L36 so the installed indicator does not work properly because the deployment url does not contain the name of the plugin/plugin repo.

Beyond the tooltips I have implemented:

• handling for various Typebox union schemas
• displaying various toggles depending on the schema
• Where unions are concerned, a tooltip with all descriptions etc, since those are rendered as a JSON object to edit vs input rows
• I've tried to add as many helpful comments as I could to make it a bit easier for anyone else that works on this

I did not open a new task as I felt submitting this PR for review without the proper handling/displaying of descriptions etc was not meeting the spec and unions required additional handling, so I apologise for going off-spec a little.

@gentlementlegen @0x4007 @rndquu - still unable to request a review so I'm having to tag, ty.

@Keyrxng It works better after removing the configuration, although it takes a very long time to display the first screen because somehow it cannot fetch mentlegen-2 organization configuration. Logic also seems to work fine. Still a few remarks:

Why are some field names having dots and other having spaces?
Text box fields still seems not aligned properly
The commit name on config update starts with chore: Plugin which is not conventional commit friendly (should not start with uppercase)

Also it seems that these kind of selectors don't work:

Ty @gentlementlegen

because somehow it cannot fetch mentlegen-2 organization configuration.

This is a little hard for me to debug. Perhaps it's a permission/visibility issue with that org?

Why are some field names having dots and other having spaces?

Params which are objects use param.prop while standalone don't require it. In your example BaseRateMultiplier is standalone while the rest are child props. I felt this was the best way to display each vs a large JSON object which could be huge like text-conversation-rewards.Incentives.

Text box fields still seems not aligned properly

My mistake forgot to remove the margin should be fixed now:

Also it seems that these kind of selectors don't work:

Added a selected state

The commit name on config update

Reworded the commit to chore: updating config (Plugin Installer UI)

QA:

Truly don't understand about that organization because it has very similar settings to the other ones, if I find something I'll let you know.
The problem to me is that during all the fetching the UI is completely empty, and the only feedback appears in the console.

Cool let me test again.

One last margin problem remaining here:

Otherwise everything seems to work fine.

On the above screenshot, each of these have a lot of configurable parameters but only a text box is shown, when I thing there should be all the inner parameters available. This is obviously outside of the scope of this pull-request but it should be addressed within another pull-request.

The problem to me is that during all the fetching the UI is completely empty, and the only feedback appears in the console.

Hmmm that's strange so for you, you don't see the toast notification saying that fetching is happening? Would a centered spinner or loader or something be prefered until all fetching has completed?

See I only have one org to fetch from these days so it's hard for me to experience having to fetch from 3 or 4 orgs which sounds like the case for you maybe.

QA:

On the above screenshot, each of these have a lot of configurable parameters but only a text box is shown, when I thing there should be all the inner parameters available. This is obviously outside of the scope of this pull-request but it should be addressed within another pull-request.

If I understand, you are suggesting that for these textareas which accompany the anyOf (union based selections) button groups, you'd prefer to render each child prop in the same way I do for a standard object using the param.prop convention?

Would we keep the buttons and collapse the rendered props for that union option if they disable it? And for those which cannot be disabled they'd stay rendered?

If you can create a clear spec for what exactly you'd prefer over this impl that would be great dude. I done it this way for a couple of reasons but I agree it's not optimal.

Yes I can write a spec. My idea would be that all the fields should be rendered recursively within a tree, so if you have an object within an objects within an object they all render. I think this is doable since you have the full object shape within the generated manifest. But again outside of the scope of this pull-request.

also yes I have to render 5 organizations which is why it is slow. Ideally some spinner or anything that lets you know something is happening.

One approval down, I'm unsure if we can merge this now or are we waiting for another? @gentlementlegen rfc please buddy

Probably @0x4007 can take a peek and give some feedback

@0x4007 seems awfully busy but I hope this can move forward asap.

I'm free to work on other tasks I just need one of my previous to be merged.

Cheers @gentlementlegen

@0x4007 if you don't have the time with upcoming events as you said, please assign another reviewer to get the 2nd approval needed for merge.

I'd trust @gentlementlegen's approval personally, the guy knows his shit but let's get this merged sooner rather than later, itching to move on.

@whilefoo fancy taking a peak my dude?

I selected my org and then tried a few repositories that already have a config but it didn't work (it seems to be a known issue from what I read in this PR), then I selected a repo that doesn't have a config and it created one but I can't select any plugins, the dropdown won't open.

Okay gents -- can we merge this? Since the purpose of the PR was for the config param tooltips and I can spec a task to handle the off-spec bugs

TY fellas. I'll do some bug hunting today, idk if one of you want to start the spec and I can update it with anything else I find? If that makes sense to do it that way I mean.